Temporarily remove yank button from crate header #2795
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm all for this. Haven't ever been 100% happy with this header button since I've introduced it. |
jtgeibel
force-pushed
the
hide-yank-button-in-crate-header
branch
2 times, most recently
from
9536a5c to
0ff5281
Compare
jtgeibel
force-pushed
the
hide-yank-button-in-crate-header
branch
from
0ff5281 to
8ace99a
Compare
|
I skipped the failing test and rebased on master so that I could deploy. @bors r=thiagoarrais |
|
📌 Commit 8ace99a has been approved by |
|
☀️ Test successful - checks-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporarily remove the yank button from the crate page until we find better placement for the button. The buttons added to the all versions page in #2623 remain.
I would like to merge this as a temporary fix to unblock deploying to production. I've opened #2794 to track adding this back.
r? @locks
cc @thiagoarrais