Merge pull request #785 from Turbo87/eslint

Replace JSHint/JSCS with ESLint

Author: locks

.eslintrc.js

@@ -0,0 +1,34 @@
+module.exports = {
+    root: true,
+    parserOptions: {
+        ecmaVersion: 2017,
+        sourceType: 'module',
+        ecmaFeatures: {
+            'experimentalObjectRestSpread': true,
+        },
+    },
+    extends: [
+        'eslint:recommended',
+        'plugin:ember-suave/recommended',
+    ],
+    env: {
+        browser: true,
+    },
+    rules: {
+        'arrow-parens': 'off',
+        'brace-style': 'off',
+        'camelcase': 'off',
+        'comma-dangle': 'off',
+        'dot-notation': 'off',
+        'indent': ['error', 4],
+        'operator-linebreak': 'off',
+        'quotes': ['error', 'single', {
+            'allowTemplateLiterals': true,
+            'avoidEscape': true,
+        }],
+
+        'ember-suave/no-const-outside-module-scope': 'off',
+        'ember-suave/no-direct-property-access': 'off',
+        'ember-suave/require-access-in-comments': 'off',
+    },
+};

.jscsrc

@@ -3,7 +3,7 @@ import Ember from 'ember';
 
 export default ApplicationAdapter.extend({
     pathForType(modelName) {
-        var decamelized = Ember.String.underscore(
+        let decamelized = Ember.String.underscore(
           Ember.String.decamelize(modelName)
         );
         return Ember.String.pluralize(decamelized);

.jshintrc

@@ -6,7 +6,7 @@ export default ApplicationAdapter.extend({
             return this._super(...arguments);
         }
         delete query.reverse;
-        var { crate } = query;
+        let { crate } = query;
         delete query.crate;
         return this.ajax(`/${this.urlPrefix()}/crates/${crate.get('id')}/reverse_dependencies`,
             'GET', { data: query });

app/adapters/category-slug.js

@@ -1,5 +1,17 @@
 import Ember from 'ember';
 
+// Colors by http://colorbrewer2.org/#type=diverging&scheme=RdBu&n=10
+const COLORS = [
+    '#67001f',
+    '#b2182b',
+    '#d6604d',
+    '#f4a582',
+    '#92c5de',
+    '#4393c3',
+    '#2166ac',
+    '#053061'
+];
+
 export default Ember.Component.extend({
     classNames: 'graph-data',
 
@@ -72,42 +84,39 @@ export default Ember.Component.extend({
             this.$().show();
         }
 
-        var myData = window.google.visualization.arrayToDataTable(data);
+        let myData = window.google.visualization.arrayToDataTable(data);
 
-        var fmt = new window.google.visualization.DateFormat({
+        let fmt = new window.google.visualization.DateFormat({
             pattern: 'LLL d, yyyy',
         });
         fmt.format(myData, 0);
 
         // use a DataView to calculate an x-day moving average
-        var days = 7;
-        var view = new window.google.visualization.DataView(myData);
-        var moving_avg_func_for_col = function(col) {
+        let days = 7;
+        let view = new window.google.visualization.DataView(myData);
+        let moving_avg_func_for_col = function(col) {
             return function(dt, row) {
                 // For the last rows (the *first* days, remember, the dataset is
                 // backwards), we cannot calculate the avg. of previous days.
                 if (row >= dt.getNumberOfRows() - days) {
                     return null;
                 }
 
-                var total = 0;
-                for (var i = days; i > 0; i--) {
+                let total = 0;
+                for (let i = days; i > 0; i--) {
                     total += dt.getValue(row + i, col);
                 }
-                var avg = total / days;
+                let avg = total / days;
                 return {
                     v: avg,
                     f: avg.toFixed(2)
                 };
             };
         };
 
-        var columns = [0]; // 0 = datetime
-        var seriesOption = {};
-        // Colors by http://colorbrewer2.org/#type=diverging&scheme=RdBu&n=10
-        var colors = ['#67001f', '#b2182b', '#d6604d', '#f4a582', '#92c5de',
-                      '#4393c3', '#2166ac', '#053061'];
-        var [headers, ] = data;
+        let columns = [0]; // 0 = datetime
+        let seriesOption = {};
+        let [headers] = data;
         // Walk over the headers/colums in reverse order, as the newest version
         // is at the end, but in the UI we want it at the top of the chart legend.
 
@@ -122,21 +131,21 @@ export default Ember.Component.extend({
             // axis), the series configuration starts with index 0.
             seriesOption[i * 2] = {
                 type: 'scatter',
-                color: colors[i % colors.length],
+                color: COLORS[i % COLORS.length],
                 pointSize: 3,
                 pointShape: 'square'
             };
             seriesOption[i * 2 + 1] = {
                 type: 'line',
-                color: colors[i % colors.length],
+                color: COLORS[i % COLORS.length],
                 lineWidth: 2,
                 curveType: 'function',
                 visibleInLegend: false
             };
         });
         view.setColumns(columns);
 
-        var chart = new window.google.visualization.ComboChart(this.get('element'));
+        let chart = new window.google.visualization.ComboChart(this.get('element'));
         chart.draw(view, {
             chartArea: { 'left': 85, 'width': '77%', 'height': '80%' },
             hAxis: {

app/adapters/dependency.js

@@ -40,9 +40,9 @@ export default Ember.Controller.extend({
     displayedAuthors: computed('currentVersion.authors.[]', function() {
         return DS.PromiseArray.create({
             promise: this.get('currentVersion.authors').then((authors) => {
-                var ret = authors.slice();
-                var others = authors.get('meta');
-                for (var i = 0; i < others.names.length; i++) {
+                let ret = authors.slice();
+                let others = authors.get('meta');
+                for (let i = 0; i < others.names.length; i++) {
                     ret.push({ name: others.names[i] });
                 }
                 return ret;
@@ -54,17 +54,17 @@ export default Ember.Controller.extend({
     anyCategories: computed.gt('categories.length', 0),
 
     currentDependencies: computed('currentVersion.dependencies', function() {
-        var deps = this.get('currentVersion.dependencies');
+        let deps = this.get('currentVersion.dependencies');
 
         if (deps === null) {
             return [];
         }
 
         return DS.PromiseArray.create({
             promise: deps.then((deps) => {
-                var non_dev = deps.filter((dep) => dep.get('kind') !== 'dev');
-                var map = {};
-                var ret = [];
+                let non_dev = deps.filter((dep) => dep.get('kind') !== 'dev');
+                let map = {};
+                let ret = [];
 
                 non_dev.forEach((dep) => {
                     if (!(dep.get('crate_id') in map)) {
@@ -79,7 +79,7 @@ export default Ember.Controller.extend({
     }),
 
     currentDevDependencies: computed('currentVersion.dependencies', function() {
-        var deps = this.get('currentVersion.dependencies');
+        let deps = this.get('currentVersion.dependencies');
         if (deps === null) {
             return [];
         }
@@ -120,26 +120,26 @@ export default Ember.Controller.extend({
 
         let extra = this.get('extraDownloads') || [];
 
-        var dates = {};
-        var versions = [];
-        for (var i = 0; i < 90; i++) {
-            var now = moment().subtract(i, 'days');
+        let dates = {};
+        let versions = [];
+        for (let i = 0; i < 90; i++) {
+            let now = moment().subtract(i, 'days');
             dates[now.format('MMM D')] = { date: now, cnt: {} };
         }
 
         downloads.forEach((d) => {
-            var version_id = d.get('version.id');
-            var key = moment(d.get('date')).utc().format('MMM D');
+            let version_id = d.get('version.id');
+            let key = moment(d.get('date')).utc().format('MMM D');
             if (dates[key]) {
-                var prev = dates[key].cnt[version_id] || 0;
+                let prev = dates[key].cnt[version_id] || 0;
                 dates[key].cnt[version_id] = prev + d.get('downloads');
             }
         });
 
         extra.forEach((d) => {
-            var key = moment(d.date).utc().format('MMM D');
+            let key = moment(d.date).utc().format('MMM D');
             if (dates[key]) {
-                var prev = dates[key].cnt[null] || 0;
+                let prev = dates[key].cnt[null] || 0;
                 dates[key].cnt[null] = prev + d.downloads;
             }
         });
@@ -157,15 +157,15 @@ export default Ember.Controller.extend({
             });
         }
 
-        var headers = ['Date'];
+        let headers = ['Date'];
         versions.sort((b) => b.num).reverse();
-        for (i = 0; i < versions.length; i++) {
+        for (let i = 0; i < versions.length; i++) {
             headers.push(versions[i].num);
         }
-        var data = [headers];
-        for (var date in dates) {
-            var row = [dates[date].date.toDate()];
-            for (i = 0; i < versions.length; i++) {
+        let data = [headers];
+        for (let date in dates) {
+            let row = [dates[date].date.toDate()];
+            for (let i = 0; i < versions.length; i++) {
                 row.push(dates[date].cnt[versions[i].id] || 0);
             }
             data.push(row);

app/components/download-graph.js

@@ -35,10 +35,10 @@ export default Ember.Controller.extend({
     actions: {
         loadMore() {
             this.set('loadingMore', true);
-            var page = (this.get('myFeed').length / 10) + 1;
+            let page = (this.get('myFeed').length / 10) + 1;
 
             ajax(`/me/updates?page=${page}`).then((data) => {
-                var versions = data.versions.map(version =>
+                let versions = data.versions.map(version =>
                     this.store.push(this.store.normalize('version', version)));
 
                 this.get('myFeed').pushObjects(versions);

app/controllers/crate/version.js

@@ -15,7 +15,7 @@ export default Ember.Controller.extend({
             }).then((d) => {
                 this.get('model').set('api_token', d.api_token);
             }).catch((reason) => {
-                var msg;
+                let msg;
                 if (reason.status === 403) {
                     msg = 'A login is required to perform this action';
                 } else {

app/controllers/dashboard.js

@@ -1,10 +1,10 @@
 import Ember from 'ember';
 
-var escape = Ember.Handlebars.Utils.escapeExpression;
+const escape = Ember.Handlebars.Utils.escapeExpression;
 
 export function formatEmail(email) {
-    var formatted = email.match(/^(.*?)\s*(?:<(.*)>)?$/);
-    var ret = '';
+    let formatted = email.match(/^(.*?)\s*(?:<(.*)>)?$/);
+    let ret = '';
 
     ret += escape(formatted[1]);
 

app/controllers/me/index.js

@@ -5,8 +5,8 @@ export function formatNum(value) {
         return '0';
     }
 
-    var ret = '';
-    var cnt = 0;
+    let ret = '';
+    let cnt = 0;
     while (value > 0) {
         if (cnt > 0 && cnt % 3 === 0) {
             ret = `,${ret}`;

app/helpers/format-email.js

@@ -1,6 +1,6 @@
 import Ember from 'ember';
 
-export var initialize = function() {
+export function initialize() {
     Ember.$.getScript('https://www.google.com/jsapi', function() {
         window.google.load('visualization', '1.0', {
             packages: ['corechart'],
@@ -10,7 +10,7 @@ export var initialize = function() {
             }
         });
     });
-};
+}
 
 export default {
     name: 'google',

app/helpers/format-num.js

@@ -2,7 +2,7 @@ import Ember from 'ember';
 
 export default Ember.Mixin.create({
     beforeModel(transition) {
-        var user = this.session.get('currentUser');
+        let user = this.session.get('currentUser');
         if (user !== null) {
             return;
         }