Switch to DELETE for /logout route to prevent CSRF
#1013
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Other sites are allowed to make `GET` requests so switchig to `DELETE` to match the destructive nature of the route. If the user navigates to `GET /logout` we now fall back to the default behavior which is to serve up the ember app. Ember then sends a `DELETE` request. Fortunately we already enforce sameorigin for iframes via the `X-FRAME-OPTIONS` header. Fixes: rust-lang#986
|
Sounds good to me! bors: r+ |
bors-voyager bot
added a commit
that referenced
this pull request
Aug 26, 2017
1013: Switch to `DELETE` for /logout route to prevent CSRF r=carols10cents Other sites are allowed to make `GET` requests so switching to `DELETE` to match the destructive nature of the route. If the user navigates to `GET /logout` we now fall back to the default behavior which is to serve up the ember app. Ember then sends a `DELETE` request. Fortunately we already enforce sameorigin for iframes via the `X-FRAME-OPTIONS` header. Fixes: #986
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other sites are allowed to make
GETrequests so switching toDELETEto match the destructive nature of the route.
If the user navigates to
GET /logoutwe now fall back to the defaultbehavior which is to serve up the ember app. Ember then sends a
DELETErequest. Fortunately we already enforce sameorigin foriframes via the
X-FRAME-OPTIONSheader.Fixes: #986