Fix Wrong AppVeyor badge #1050
Merged
Fix Wrong AppVeyor badge #1050
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is part of fixing issue rust-lang#693 ✅ Add an id field with type Option<String> to the Appveyor badge enum variant ✅ Add id: alias('badge.attributes.id') to the appveyor badge component ✅ Add an image-url attribute, computed from the id to the appveyor badge component that checks to see if id is defined. (I've used `imageUrl` as attribute) ✅ Change the appveyor badge template to use the image-url attribute for the img src instead ✅ Publish a crate to your local instance that has the URLs dtolnay has listed for serde and manually verify the badge is displayed correctly.
added `id` field
|
Hi @carols10cents @dtolnay. Kindly review this PR for issue #693 |
dtolnay
reviewed
Sep 15, 2017
|
Hi @mattgathu! Sorry for the delay on reviewing this-- I'm going to be pretty busy today and this weekend prepping for the start of the impl period, but I will try to get to this next week :) Thank you for your PR!! |
carols10cents
requested changes
Sep 20, 2017
app/components/badge-appveyor.js
Outdated
| imageUrl: computed('badge.attributes.id', function() { | ||
| let id = this.get('badge.attributes.id'); | ||
| let branch = this.get('branch'); | ||
| if (id === undefined || id === null) { |
There was a problem hiding this comment.
I think this condition is backwards? This says if id IS undefined or id IS null, then try to use id? This should be (id !== undefined && id !== null), yeah? I tried making a badge using only repository and id and the id isn't appearing in the image url :(
|
@mattgathu I think the operator also needs to be switched from |
|
@carols10cents @jtgeibel thank you for the bug catch! I've fixed it. |
carols10cents
approved these changes
Sep 23, 2017
|
Thank you!!! Works great now!!! bors: r+ |
bors-voyager bot
added a commit
that referenced
this pull request
Sep 23, 2017
1050: Fix Wrong AppVeyor badge r=carols10cents this is part of fixing issue #693 - [x] Add an id field with type Option<String> to the Appveyor badge enum variant - [x] Add id: alias('badge.attributes.id') to the appveyor badge component - [x] Add an image-url attribute, computed from the id to the appveyor badge component that checks to see if id is defined. (I've used `imageUrl` as attribute) - [x] Change the appveyor badge template to use the image-url attribute for the img src instead - [x] Publish a crate to your local instance that has the URLs dtolnay has listed for serde and manually verify the badge is displayed correctly. - [x] Send a pull request to cargo to update the badge documentation to indicate you can specify the appveyor project id if you want to use that instead. (_https://github.com/rust-lang/cargo/pull/4489_)
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is part of fixing issue #693
Add an id field with type Option to the Appveyor badge enum variant
Add id: alias('badge.attributes.id') to the appveyor badge component
Add an image-url attribute, computed from the id to the appveyor badge component that checks to see if id is defined. (I've used
imageUrlas attribute)Change the appveyor badge template to use the image-url attribute for the img src instead
Publish a crate to your local instance that has the URLs dtolnay has listed for serde and manually verify the badge is displayed correctly.
Send a pull request to cargo to update the badge documentation to indicate you can specify the appveyor project id if you want to use that instead. (Update Appveyor badge docs cargo#4489)