Update database schema to match the code #1133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are a handful of differences between what we say our schema is in the code, and what it actually is. These differences make schema.rs harder to regenerate, and can potentially lead to real issues down the line. This removes all of the differences between the real schema and what we say it is in Rust.
|
So this is better, but when I'm on this branch and run |
Merged
1 task
|
Yeah, there's not really any way for |
|
Ok, I'll think about how to handle the other issues and merge this in the meantime. bors: r+ |
bors-voyager bot
added a commit
that referenced
this pull request
Oct 24, 2017
1133: Update database schema to match the code r=carols10cents There are a handful of differences between what we say our schema is in the code, and what it actually is. These differences make schema.rs harder to regenerate, and can potentially lead to real issues down the line. This removes all of the differences between the real schema and what we say it is in Rust.
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a handful of differences between what we say our schema is in
the code, and what it actually is. These differences make schema.rs
harder to regenerate, and can potentially lead to real issues down the
line. This removes all of the differences between the real schema and
what we say it is in Rust.