Improve build times by caching cargo install artifacts for diesel, clippy, and rustfmt
#1216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…clippy, and rustfmt The primary change is to set `CARGO_TARGET_DIR=target` which instructs `cargo install` to use the target/ directory which is cached between builds on travis. This is only available on recent nightlies so I've bumped clippy and rustfmt versions. Unfortunately, `ring v0.11.0` does not compile on recent nightlies and upstream provides no support for older versions. Therefore I've added a patch section to use a git repo that incorporates the fix and a few other cleanups. This issue would have broken the build soon anyway when rust 1.24 goes into beta. A few other changes: * only `npm install` on the stable job * removed travis-cargo which appears to be unused * removed rustfmt configuration options that were removed upstream
jtgeibel
added
the
C-internal 🔧
I'm assuming this was compiled with `--debug` previously to reduce build times. Now that `cargo target` is cached on CI, it seems fine to build this with optimizations enabled.
jtgeibel
force-pushed
the
cargo-target-dir
branch
from
1b5bd6a to
c8cd197
Compare
Merged
|
i like faster! bors: r+ |
bors-voyager bot
added a commit
that referenced
this pull request
Jan 4, 2018
1216: Improve build times by caching `cargo install` artifacts for diesel, clippy, and rustfmt r=carols10cents The primary change is to set `CARGO_TARGET_DIR=target` which instructs `cargo install` to use the target/ directory which is cached between builds on travis. This is only available on recent nightlies so I've bumped clippy and rustfmt versions. Unfortunately, `ring v0.11.0` does not compile on recent nightlies and upstream provides no support for older versions. Therefore I've added a patch section to use a git repo that incorporates the fix and a few other cleanups. This issue would have broken the build soon anyway when rust 1.24 goes into beta. A few other changes: * only `npm install` on the stable job * removed travis-cargo which appears to be unused * removed rustfmt configuration options that were removed upstream
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary change is to set
CARGO_TARGET_DIR=targetwhich instructscargo installto use the target/ directory which is cached between builds on travis. This is only available on recent nightlies so I've bumped clippy and rustfmt versions.Unfortunately,
ring v0.11.0does not compile on recent nightlies and upstream provides no support for older versions. Therefore I've added a patch section to use a git repo that incorporates the fix and a few other cleanups. This issue would have broken the build soon anyway when rust 1.24 goes into beta.A few other changes:
npm installon the stable job