Update to Diesel 1.1 #1234
Merged
Update to Diesel 1.1 #1234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the minimum changes required to fix any deprecation warnings. There's a lot of additional stuff we could do that I wanted to keep separate. After updating to Diesel 1.1, we can remove virtually anywhere that we're doing an explicit `&*`. Additionally, there are probably a lot of places that we should be using custom types but aren't. We can remove a lot of code once dtolnay/semver#169 is merged/released as well.
|
\o/ bors: r+ |
bors-voyager bot
added a commit
that referenced
this pull request
Jan 18, 2018
1234: Update to Diesel 1.1 r=carols10cents This is the minimum changes required to fix any deprecation warnings. There's a lot of additional stuff we could do that I wanted to keep separate. After updating to Diesel 1.1, we can remove virtually anywhere that we're doing an explicit `&*`. Additionally, there are probably a lot of places that we should be using custom types but aren't. We can remove a lot of code once dtolnay/semver#169 is merged/released as well.
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the minimum changes required to fix any deprecation warnings.
There's a lot of additional stuff we could do that I wanted to keep
separate. After updating to Diesel 1.1, we can remove virtually anywhere
that we're doing an explicit
&*. Additionally, there are probably alot of places that we should be using custom types but aren't. We can
remove a lot of code once
dtolnay/semver#169 is merged/released as well.