Skip to content

[UI UPDATE]: Based on issue #1148, widen main to prevent icon overflow #1242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 25, 2018

Conversation

someguynamedmatt
Copy link
Contributor

Slight widening to the main section of a given crates page based on issue #1148, overflow now prevented

@Turbo87
Copy link
Member

Turbo87 commented Jan 20, 2018

@someguynamedmatt can you add before/after screenshots?

@Turbo87 Turbo87 added the A-CSS label Jan 20, 2018
@someguynamedmatt
Copy link
Contributor Author

someguynamedmatt commented Jan 20, 2018

@Turbo87 Definitely. It's sorta difficult to get a screenshot of the change, because what I've done is change the threshold of the @media switch (desktop -> mobile) to 890px from 830px. If the badge is intended to stay at that position in the interface, that's the constraint for how narrow the desktop view can be. Here's a screenshot of what it looks like just before it switches to the mobile view:

Before

before_digitalocean

After
after_digitalocean

@Turbo87
Copy link
Member

Turbo87 commented Jan 21, 2018

I see, thanks. I will let @carols10cents decide on this one.

@carols10cents
Copy link
Member

Looks good to me! Thank you!! ❤️

bors: r+

bors-voyager bot added a commit that referenced this pull request Jan 25, 2018
1242: [UI UPDATE]: Based on issue #1148, widen main to prevent icon overflow r=carols10cents

Slight widening to the `main` section of a given crates page based on issue #1148, overflow now prevented
@bors-voyager
Copy link
Contributor

bors-voyager bot commented Jan 25, 2018

Build succeeded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants