More MVC Refactoring #1255
Merged
More MVC Refactoring #1255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is failing due to whitespace issues introduced by me using a newer rustfmt locally. I've opened #1256 and will rebase once that is merged. Tests are otherwise green. |
There is still more work to do to extract model logic from some of the controller endpoints, however I'm focusing on getting things moved around in bulk first, and then focus on extracting logic when practical.
jtgeibel
force-pushed
the
more-mvc-refactoring
branch
from
faa91e0 to
f69ccb8
Compare
|
\o/ bors: r+ |
bors-voyager bot
added a commit
that referenced
this pull request
Feb 22, 2018
1255: More MVC Refactoring r=carols10cents
This PR splits several existing source files into the MVC submodules. Here is a summary of the changes per commit:
* Split `krate.rs`
* Moved `WithCount` under `models::helpers`.
* Moved `follow` into its own model.
* Added an `ok_true()` function under `controllers::helpers` that returns a json result of `{ok: true}`. There are several additional places under `user` and `version` where this can be used as they are moved over.
* Split `badge.rs` - straightforward
* Extract `rights.rs` into a model used by `User`
* Moved the `Rights` enum to its own file under models.
* Moved `rights` from a free-standing function to a method on `User`.
* Split `owner.rs`
* This splits the functionality into two models: `Owner` and `Team`.
* `Team::github_url()` was moved to `github::team_url` to be alongside other Github related code.
* Split `crate_owner_invitations` - straightforward, and removes some duplicate `InvitationResponse` structs from the tests.
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits several existing source files into the MVC submodules. Here is a summary of the changes per commit:
krate.rsWithCountundermodels::helpers.followinto its own model.ok_true()function undercontrollers::helpersthat returns a json result of{ok: true}. There are several additional places underuserandversionwhere this can be used as they are moved over.badge.rs- straightforwardrights.rsinto a model used byUserRightsenum to its own file under models.rightsfrom a free-standing function to a method onUser.owner.rsOwnerandTeam.Team::github_url()was moved togithub::team_urlto be alongside other Github related code.crate_owner_invitations- straightforward, and removes some duplicateInvitationResponsestructs from the tests.