Fix relevance sorting on search #1371
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To sort by relevence, the backend expects the sort string to either be not present, or set to the value "relevance". Right now the backend is either sending the string `null` or an empty string. Neither of these do what we want. Fixes rust-lang#1370
ashleygwilliams
approved these changes
Apr 26, 2018
|
bors: r+ |
bors-voyager bot
added a commit
that referenced
this pull request
Apr 26, 2018
1371: Fix relevance sorting on search r=ashleygwilliams To sort by relevence, the backend expects the sort string to either be not present, or set to the value "relevance". Right now the backend is either sending the string `null` or an empty string. Neither of these do what we want. Fixes #1370
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To sort by relevence, the backend expects the sort string to either be
not present, or set to the value "relevance". Right now the backend is
either sending the string
nullor an empty string. Neither of these dowhat we want.
Fixes #1370