Require all traffic to provide a User-Agent header.
#1534
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to be able to actually differentiate crawlers from each other, so I've nudged them towards actually using a unique user agent (we probably won't ever actually block generic UAs since folks sometimes do actually use curl/wget from the command line). Additionally, I've had a lot of cases lately where a crawler has been outside of what we allow, but wasn't actually causing a service impact. If I could contact those people without having to block their traffic, I would. So I've also worded the message to try and nudge folks towards including contact info, which most commercial bots already do.
It was necessary to check the response status manually, because the bad_resp! macro expects to be able to decode a JSON response.
jtgeibel
approved these changes
Oct 24, 2018
|
bors: r+ |
bors-voyager bot
added a commit
that referenced
this pull request
Oct 24, 2018
1534: Require all traffic to provide a `User-Agent` header. r=sgrif a=sgrif We want to be able to actually differentiate crawlers from each other, so I've nudged them towards actually using a unique user agent (we probably won't ever actually block generic UAs since folks sometimes do actually use curl/wget from the command line). Additionally, I've had a lot of cases lately where a crawler has been outside of what we allow, but wasn't actually causing a service impact. If I could contact those people without having to block their traffic, I would. So I've also worded the message to try and nudge folks towards including contact info, which most commercial bots already do. Co-authored-by: Sean Griffin <[email protected]> Co-authored-by: Justin Geibel <[email protected]>
Build succeeded |
|
AIUI, cargo didn't set any User-Agent until rust-lang/cargo#3485, which is in cargo 0.17.0 -> rust 1.16. Does this PR mean that earlier versions of cargo won't be able to fetch from crates.io at all? |
|
Yes, we learned that yesterday afternoon. This change has since been reverted and we're going to be discussing it during the next team meeting. |
|
OK, thanks for the info! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to be able to actually differentiate crawlers from each other,
so I've nudged them towards actually using a unique user agent (we
probably won't ever actually block generic UAs since folks sometimes do
actually use curl/wget from the command line).
Additionally, I've had a lot of cases lately where a crawler has been
outside of what we allow, but wasn't actually causing a service impact.
If I could contact those people without having to block their traffic, I
would. So I've also worded the message to try and nudge folks towards
including contact info, which most commercial bots already do.