Bump semver #1537
Merged
Bump semver #1537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The amount of manual serialization/deserialization of semver stuff is really starting to get in the way of refactoring. Semver supports both Serde and Diesel on master (only serde in the released version, hence the git dependency). Conduit still expects an older version though. That project is unmaintained and I've been having trouble getting added as an owner to publish a new version (Alex is in Europe right now, not worth bothering him) so we've got a little hacky workaround in the meantime.
|
Sounds good to me. bors: r+ |
bors-voyager bot
added a commit
that referenced
this pull request
Oct 24, 2018
1537: Bump semver r=jtgeibel a=sgrif The amount of manual serialization/deserialization of semver stuff is really starting to get in the way of refactoring. Semver supports both Serde and Diesel on master (only serde in the released version, hence the git dependency). Conduit still expects an older version though. That project is unmaintained and I've been having trouble getting added as an owner to publish a new version (Alex is in Europe right now, not worth bothering him) so we've got a little hacky workaround in the meantime. Co-authored-by: Sean Griffin <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The amount of manual serialization/deserialization of semver stuff is
really starting to get in the way of refactoring. Semver supports both
Serde and Diesel on master (only serde in the released version, hence
the git dependency).
Conduit still expects an older version though. That project is
unmaintained and I've been having trouble getting added as an owner to
publish a new version (Alex is in Europe right now, not worth bothering
him) so we've got a little hacky workaround in the meantime.