Ensure only exact name matches are added to the index #1550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On the client side cargo checks dependency names against the index and requires an exact match. For instance, a user cannot depend on `diesel-migrations` or `Diesel_migrations` as cargo generates an error directing them to use the correct name `diesel_migrations`. This check for an exact name match is now repeated on the server when a crate is published. This ensures that bugs in cargo or third-party tooling cannot result in a dependency name that cargo is unable to locate in the index.
|
bors: r+ |
bors-voyager bot
added a commit
that referenced
this pull request
Nov 5, 2018
1550: Ensure only exact name matches are added to the index r=sgrif a=jtgeibel On the client side cargo checks dependency names against the index and requires an exact match. For instance, a user cannot depend on `diesel-migrations` or `Diesel_migrations` as cargo generates an error directing them to use the correct name `diesel_migrations`. This check for an exact name match is now repeated on the server when a crate is published. This ensures that bugs in cargo or third-party tooling cannot result in a dependency name that cargo is unable to locate in the index. Co-authored-by: Justin Geibel <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the client side cargo checks dependency names against the index and
requires an exact match. For instance, a user cannot depend on
diesel-migrationsorDiesel_migrationsas cargo generates an errordirecting them to use the correct name
diesel_migrations.This check for an exact name match is now repeated on the server when a
crate is published. This ensures that bugs in cargo or third-party
tooling cannot result in a dependency name that cargo is unable to
locate in the index.