Prepare for clippy and rustfmt in rust-2018 #1570
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors: r+ |
bors-voyager bot
added a commit
that referenced
this pull request
Dec 6, 2018
1570: Prepare for clippy and rustfmt in rust-2018 r=jtgeibel a=jtgeibel The first commit includes minor updates recommended by the clippy version which will be released with rust stable tomorrow. In particular it uses the new lint attribute syntax like `#[allow(clippy::too_many_arguments)]`. The second commit applies rustfmt changes. This PR will fail on CI for now, but can be merged after the new stable release is published. Co-authored-by: Justin Geibel <[email protected]>
Timed out |
|
It looks like GitHub never started a build. Let's try again. bors: r+ |
bors-voyager bot
added a commit
that referenced
this pull request
Dec 6, 2018
1570: Prepare for clippy and rustfmt in rust-2018 r=jtgeibel a=jtgeibel The first commit includes minor updates recommended by the clippy version which will be released with rust stable tomorrow. In particular it uses the new lint attribute syntax like `#[allow(clippy::too_many_arguments)]`. The second commit applies rustfmt changes. This PR will fail on CI for now, but can be merged after the new stable release is published. Co-authored-by: Justin Geibel <[email protected]>
Timed out |
|
bors: r+ |
bors-voyager bot
added a commit
that referenced
this pull request
Dec 6, 2018
1570: Prepare for clippy and rustfmt in rust-2018 r=jtgeibel a=jtgeibel The first commit includes minor updates recommended by the clippy version which will be released with rust stable tomorrow. In particular it uses the new lint attribute syntax like `#[allow(clippy::too_many_arguments)]`. The second commit applies rustfmt changes. This PR will fail on CI for now, but can be merged after the new stable release is published. Co-authored-by: Justin Geibel <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit includes minor updates recommended by the clippy version which will be released with rust stable tomorrow. In particular it uses the new lint attribute syntax like
#[allow(clippy::too_many_arguments)]. The second commit applies rustfmt changes.This PR will fail on CI for now, but can be merged after the new stable release is published.