Split the two uses of version::deprecated::show into separate fns #1614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Discovered that /crates/:crate_id/:version is used in the show_version test RequestHelper function, so it probably shouldn't be marked as deprecated even though the frontend isn't using it. Takes care of the FIXME comment.
|
I remember writing that FIXME, glad to see this resolved! Great catch that this is used in the @bors r+ |
|
📌 Commit 6fa54eb has been approved by |
bors
added a commit
that referenced
this pull request
Feb 2, 2019
Split the two uses of version::deprecated::show into separate fns Discovered that /crates/:crate_id/:version is used in the show_version test RequestHelper function, so it probably shouldn't be marked as deprecated even though the frontend isn't using it. Takes care of the FIXME comment.
|
☀️ Test successful - checks-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered that /crates/:crate_id/:version is used in the show_version
test RequestHelper function, so it probably shouldn't be marked as
deprecated even though the frontend isn't using it.
Takes care of the FIXME comment.