Allow profiling jemalloc #1649
Merged
Allow profiling jemalloc #1649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This builds jemalloc with profiling enabled, and preserves debug symbols in the release binary (note: `debug = true` does not disable optimizations). This commit by itself doesn't actually perform any profiling, but it allows it to be controlled by an environment variable. At this point I cannot get any useful information about the memory issue we're seeing in production locally. We also can't reproduce it in a staging environment. There's *something* about our production traffic patterns that we're missing, so the next step is to start looking at dumps of production memory usage. My intention is to start enabling sampling based profiling in production, and copy some of the dumps off the server to examine locally.
|
These changes seem fine to me. @bors r+ |
|
📌 Commit a4d2585 has been approved by |
bors
added a commit
that referenced
this pull request
Mar 8, 2019
Allow profiling jemalloc This builds jemalloc with profiling enabled, and preserves debug symbols in the release binary (note: `debug = true` does not disable optimizations). This commit by itself doesn't actually perform any profiling, but it allows it to be controlled by an environment variable. At this point I cannot get any useful information about the memory issue we're seeing in production locally. We also can't reproduce it in a staging environment. There's *something* about our production traffic patterns that we're missing, so the next step is to start looking at dumps of production memory usage. My intention is to start enabling sampling based profiling in production, and copy some of the dumps off the server to examine locally.
|
☀️ Test successful - checks-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds jemalloc with profiling enabled, and preserves debug symbols
in the release binary (note:
debug = truedoes not disableoptimizations). This commit by itself doesn't actually perform any
profiling, but it allows it to be controlled by an environment variable.
At this point I cannot get any useful information about the memory issue
we're seeing in production locally. We also can't reproduce it in a
staging environment. There's something about our production traffic
patterns that we're missing, so the next step is to start looking at
dumps of production memory usage.
My intention is to start enabling sampling based profiling in
production, and copy some of the dumps off the server to examine
locally.