Fingerprinting SVGs #1741
Merged
Fingerprinting SVGs #1741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the production build all the SVGs are copied into dist/assets without fingerprints. All other assets have fingerprints. Since all files in dist/assets are served with far-future cache headers there would be cache issues if the files were ever updated. This is not major issue as these files are not used in normal operations. Closes rust-lang#1575
|
I checked this by inspecting the dist/assets folder and then ensured the homepage rendered properly using |
|
Thanks for tracking this down @markcatley. @bors r+ |
|
📌 Commit c6d1853 has been approved by |
bors
added a commit
that referenced
this pull request
May 8, 2019
Fingerprinting SVGs In the production build all the SVGs are copied into dist/assets without fingerprints. All other assets have fingerprints. Since all files in dist/assets are served with far-future cache headers there would be cache issues if the files were ever updated. This is not major issue as these files are not used in normal operations. Closes #1575
|
☀️ Test successful - checks-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the production build all the SVGs are copied into dist/assets without fingerprints. All other assets have fingerprints. Since all files in dist/assets are served with far-future cache headers there would be cache issues if the files were ever updated. This is not major issue as these files are not used in normal operations.
Closes #1575