Finish updating tests #1760
Merged
Finish updating tests #1760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtgeibel
approved these changes
Jun 26, 2019
| req.mut_extensions() | ||
| .insert(AuthenticationSource::SessionCookie); | ||
| } | ||
|
|
There was a problem hiding this comment.
🎉 I'm so glad to see this go away, along with logout and the *_resp! macros
|
@bors: r+ |
|
📌 Commit 9e79038 has been approved by |
bors
added a commit
that referenced
this pull request
Jun 26, 2019
Finish updating tests This converts the remaining tests to the newer test API, so that we can continue to move forward with improvements without some of the tests lagging behind. I do think there's more to be done to make the tests easier to read, write, and debug, and I am introducing some duplication and abstractions I'm not happy with. Next pass though.
|
☀️ Test successful - checks-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This converts the remaining tests to the newer test API, so that we can continue to move forward with improvements without some of the tests lagging behind.
I do think there's more to be done to make the tests easier to read, write, and debug, and I am introducing some duplication and abstractions I'm not happy with. Next pass though.