Rerun the build script if .env has been changed.
#1773
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Edits to `.env` may alter the value of the `TEST_DATABASE_URL` environment variable, so we should rerun the build script if `.env` was changed. The build script is already configured to be rerun when the value of `TEST_DATABASE_URL` changes, but the current setup does not capture changes performed via `.env`, since the environment file is only loaded at runtime of the build script. This change also removes the redundant `cargo:rerun-if-changed=build.rs`; the build script is always rerun if it is changed.
|
@bors: r+ |
|
📌 Commit 2653c12 has been approved by |
bors
added a commit
that referenced
this pull request
Jun 24, 2019
Rerun the build script if `.env` has been changed. Edits to `.env` may alter the value of the `TEST_DATABASE_URL` environment variable, so we should rerun the build script if `.env` was changed. The build script is already configured to be rerun when the value of `TEST_DATABASE_URL` changes, but the current setup does not capture changes performed via `.env`, since the environment file is only loaded at runtime of the build script. This change also removes the redundant `cargo:rerun-if-changed=build.rs`; the build script is always rerun if it is changed.
|
☀️ Test successful - checks-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edits to
.envmay alter the value of theTEST_DATABASE_URLenvironment variable, so we shouldrerun the build script if
.envwas changed. The build script is already configured to be rerunwhen the value of
TEST_DATABASE_URLchanges, but the current setup does not capture changesperformed via
.env, since the environment file is only loaded at runtime of the build script.This change also removes the redundant
cargo:rerun-if-changed=build.rs; the build script is alwaysrerun if it is changed.