Skip to content

Fix ESLINT_LEGACY_OBJECT_REST_SPREAD and upgrade eslint #1831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 8, 2019

Conversation

kzys
Copy link
Contributor

@kzys kzys commented Sep 7, 2019

ES2018 supports the feature officially, and eslint deprecated
experimentalObjectRestSpread because of that.

The warning is also coming from eslint-plugin-ember.
That's why the plugin is updated.

ES2018 supports the feature officially, and eslint deprecated
`experimentalObjectRestSpread` because of that.

The warning is also coming from eslint-plugin-ember.
That's why the plugin is updated.
@rust-highfive
Copy link

r? @carols10cents

(rust_highfive has picked a reviewer for you, use r? to override)

@kzys kzys changed the title Fix ESLINT_LEGACY_OBJECT_REST_SPREAD Fix ESLINT_LEGACY_OBJECT_REST_SPREAD and update eslint Sep 7, 2019
@kzys kzys changed the title Fix ESLINT_LEGACY_OBJECT_REST_SPREAD and update eslint Fix ESLINT_LEGACY_OBJECT_REST_SPREAD and upgrade eslint Sep 7, 2019
@locks
Copy link
Contributor

locks commented Sep 8, 2019

@bors r+

@bors
Copy link
Contributor

bors commented Sep 8, 2019

📌 Commit 5f9bf7b has been approved by locks

@bors
Copy link
Contributor

bors commented Sep 8, 2019

⌛ Testing commit 5f9bf7b with merge b4a6c66...

bors added a commit that referenced this pull request Sep 8, 2019
Fix ESLINT_LEGACY_OBJECT_REST_SPREAD and upgrade eslint

ES2018 supports the feature officially, and eslint deprecated
`experimentalObjectRestSpread` because of that.

The warning is also coming from eslint-plugin-ember.
That's why the plugin is updated.
@bors
Copy link
Contributor

bors commented Sep 8, 2019

☀️ Test successful - checks-travis
Approved by: locks
Pushing b4a6c66 to master...

@bors bors merged commit 5f9bf7b into rust-lang:master Sep 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants