Skip to content

Fix ESLint issues #1833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 8, 2019
Merged

Fix ESLint issues #1833

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e9f8458
Fix indentation
kzys Sep 8, 2019
f953451
Remove unnecessary rules
kzys Sep 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions .eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,6 @@ module.exports = {
},
rules: {
'prettier/prettier': 'error',

'arrow-parens': 'off',
'brace-style': 'off',
camelcase: 'off',
'comma-dangle': 'off',
'dot-notation': 'off',
'operator-linebreak': 'off',

'ember/no-observers': 'warn',
'ember/no-new-mixins': 'warn',
'ember/require-return-from-computed': 'warn',
Expand Down
18 changes: 9 additions & 9 deletions app/mixins/rl-dropdown-component.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,8 @@ export default Mixin.create({

if (this.dropdownExpanded) {
/* Add clickout handler with 1ms delay, to allow opening the dropdown
* by clicking e.g. a checkbox and binding to dropdownExpanded, without
* having the handler close the dropdown immediately. */
* by clicking e.g. a checkbox and binding to dropdownExpanded, without
* having the handler close the dropdown immediately. */
later(() => {
$document.bind(clickEventName, { component }, component.boundClickoutHandler);
$document.bind(focusEventName, { component }, component.boundClickoutHandler);
Expand Down Expand Up @@ -96,13 +96,13 @@ export default Mixin.create({
let $target = $(event.target);

/* There is an issue when the click triggered a dom change in the
* dropdown that unloaded the target element. The ancestry of the target
* can no longer be determined. We can check if html is still an ancestor
* to determine if this has happened. The safe option then seems to be to
* not close the dropdown, as occasionaly not closing the dropdown when it
* should have closed, seems to be less bad for usability than occasionaly
* closing the dropdown when it should not have closed.
*/
* dropdown that unloaded the target element. The ancestry of the target
* can no longer be determined. We can check if html is still an ancestor
* to determine if this has happened. The safe option then seems to be to
* not close the dropdown, as occasionaly not closing the dropdown when it
* should have closed, seems to be less bad for usability than occasionaly
* closing the dropdown when it should not have closed.
*/
if (
component.get('dropdownExpanded') &&
$target.closest('html').length &&
Expand Down