Skip to content

Migration to remove an index already removed from prod by hand #1845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2019

Conversation

carols10cents
Copy link
Member

This index doesn't exist in production currently, but it still exists in a db created from this codebase because we never made a migration to remove it.

Should be a no-op on prod so can be merged and deployed at any time.

@rust-highfive
Copy link

r? @sgrif

(rust_highfive has picked a reviewer for you, use r? to override)

@carols10cents carols10cents force-pushed the remove-index-in-a-migration branch from dd7aef5 to 38840b9 Compare September 19, 2019 19:22
@sgrif
Copy link
Contributor

sgrif commented Sep 23, 2019

I suspect the reason it was removed is because it would be unused as it's redundant with the unique_num index. I'm not sure why that wasn't done with a migration, as it definitely should have been.

@sgrif
Copy link
Contributor

sgrif commented Sep 23, 2019

@bors: r+

@bors
Copy link
Contributor

bors commented Sep 23, 2019

📌 Commit 38840b9 has been approved by sgrif

@bors
Copy link
Contributor

bors commented Sep 23, 2019

⌛ Testing commit 38840b9 with merge eb60255...

bors added a commit that referenced this pull request Sep 23, 2019
Migration to remove an index already removed from prod by hand

This index doesn't exist in production currently, but it still exists in a db created from this codebase because we never made a migration to remove it.

Should be a no-op on prod so can be merged and deployed at any time.
@bors
Copy link
Contributor

bors commented Sep 23, 2019

☀️ Test successful - checks-travis
Approved by: sgrif
Pushing eb60255 to master...

@bors bors merged commit 38840b9 into rust-lang:master Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants