Updated crate.scss #1856
Updated crate.scss #1856
Conversation
1. Fixed table from overflowing when the width is too large. 2. Removed a pointless CSS property. See https://developer.mozilla.org/en-US/docs/Web/CSS/float `inline-block` is ignored due to the `float`. If `float` has a value other than `none`, the box is floated and `display` is treated as `block`.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jtgeibel (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
app/styles/crate.scss
Outdated
| @@ -341,6 +341,9 @@ | |||
|
|
|||
| table { | |||
| border-collapse: collapse; | |||
| display: block; | |||
| overflow-x: auto; | |||
| white-space: wrap; | |||
There was a problem hiding this comment.
I don't think we need this property (and wrap isn't a valid value anyway).
app/styles/crate.scss
Outdated
| @@ -466,7 +469,6 @@ | |||
| .small { margin-left: 20px; display: inline-block; } | |||
| a.arrow { | |||
| display: inline-block; | |||
| float: right; | |||
There was a problem hiding this comment.
Removing this does change the semantics – the arrow won't be a float anymore, and it's not moved to the right side of the containing element anymore. It does not appear to make a difference on modern browsers because the containing element has justify-content: space-between;, which also results in moving the arrow to the right, but I'd be careful and just leave this in.
Added `float` back and remove an unnecessary value... Should I merge this?
|
Should I merge these commits? |
|
LGTM! @bors r+ |
|
📌 Commit d4905d1 has been approved by |
Updated crate.scss 1. Fixed table from overflowing when the width is too large. 2. Removed a pointless CSS property. See https://developer.mozilla.org/en-US/docs/Web/CSS/float `inline-block` is ignored due to the `float`. If `float` has a value other than `none`, the box is floated and `display` is treated as `block`. Fixes: #1638
|
☀️ Test successful - checks-travis |
inline-blockis ignored due to thefloat.If
floathas a value other thannone, the box is floated anddisplayis treated asblock.Fixes: #1638