Replace jQuery logic with native DOM #1880
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @smarnach (rust_highfive has picked a reviewer for you, use r? to override) |
locks
force-pushed
the
jquery-integration
branch
2 times, most recently
from
cedbe79 to
1334323
Compare
locks
changed the title
kzys
reviewed
Nov 12, 2019
Comment on lines
+19
to
+20
| let $target = event.target; | ||
| let $c = this.element; |
There was a problem hiding this comment.
Both of them are not jQuery objects anymore. It would be better to remove $ from the names.
There was a problem hiding this comment.
I left them as is to minimize the changes in the code. Also, this code will likely be changed or moved in a subsequent pass.
|
Looks great! Locally, in Firefox, I tested:
and everything worked as expected. Thanks!!! @bors r+ |
|
📌 Commit c6c87e1 has been approved by |
bors
added a commit
that referenced
this pull request
Nov 15, 2019
Replace jQuery logic with native DOM
|
☀️ Test successful - checks-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.