Add CloudFront IP ranges as trusted for real_ip #1906
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change will allow nginx to recurse past the CloudFront IP addresses and store the correct client IP address in `$remote_addr`. It is important that the correct client IP is available for rate limiting on the publish endpoint and logging. This list will need to be updated periodically.
|
r? @sgrif (rust_highfive has picked a reviewer for you, use r? to override) |
pietroalbini
approved these changes
Nov 19, 2019
|
@bors: r+ |
|
📌 Commit a35c6ea has been approved by |
bors
added a commit
that referenced
this pull request
Nov 19, 2019
Add CloudFront IP ranges as trusted for real_ip This change will allow nginx to recurse past the CloudFront IP addresses and store the correct client IP address in `$remote_addr`. It is important that the correct client IP is available for rate limiting on the publish endpoint and logging. This list will need to be updated periodically. cc @pietroalbini - This should probably be deployed before we enable CloudFront on production.
|
I'd like to just replace this with something that pulls from its API at boot time rather than having to remember to update the list periodically, but this is fine for now |
|
☀️ Test successful - checks-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will allow nginx to recurse past the CloudFront IP
addresses and store the correct client IP address in
$remote_addr.It is important that the correct client IP is available for rate
limiting on the publish endpoint and logging.
This list will need to be updated periodically.
cc @pietroalbini - This should probably be deployed before we enable CloudFront on production.