Add -D warnings to RUSTFLAGS on CI
#1932
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By denying warnings explicitly on CI, we don't need to deny warnings in library or binary. `#![warn(clippy::all)]` is used to automatically enable clippy in RLS enabled IDEs. `rust_2018_idioms` is now applied consistently.
|
r? @smarnach (rust_highfive has picked a reviewer for you, use r? to override) |
carols10cents
force-pushed
the
clippy-cleanups
branch
from
cb06e8e to
d2ed9de
Compare
|
Works great!! Thank you, this should hopefully remove some friction of local development! @bors r+ |
|
📌 Commit d2ed9de has been approved by |
bors
added a commit
that referenced
this pull request
Dec 5, 2019
Add `-D warnings` to `RUSTFLAGS` on CI By denying warnings explicitly on CI, we don't need to deny warnings in each library or binary. `#![warn(clippy::all)]` is used to automatically enable clippy in RLS enabled IDEs and `rust_2018_idioms` is now applied consistently. Finally, clippy allow attributes that are no longer needed have been removed.
|
☀️ Test successful - checks-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By denying warnings explicitly on CI, we don't need to deny warnings in each library or binary.
#![warn(clippy::all)]is used to automatically enable clippy in RLS enabled IDEs andrust_2018_idiomsis now applied consistently. Finally, clippy allow attributes that are no longer needed have been removed.