Use ember-css-modules for automatic style scoping
#2111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
force-pushed
the
css-modules
branch
3 times, most recently
from
72b3da1 to
cfe46cf
Compare
|
@bors r+ |
|
📌 Commit 0b5082d has been approved by |
bors
added a commit
that referenced
this pull request
Jan 13, 2020
Use `ember-css-modules` for automatic style scoping This PR allows us to use per-component/route CSS modules from now on. More information is available at https://github.com/salsify/ember-css-modules, but the tl;dr is that these files are automatically scoped to the corresponding component/route, which reduces the potential for class name conflicts. Unfortunately, our CSS is currently a bit of a 🍝 bowl, so it will take some time to untangle this into properly scoped modules. r? @locks
|
☀️ Test successful - checks-travis |
This was referenced Jan 13, 2020
JonathanHelianthicusDoe
added a commit
to JonathanHelianthicusDoe/crates.io
that referenced
this pull request
Jan 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows us to use per-component/route CSS modules from now on. More information is available at https://github.com/salsify/ember-css-modules, but the tl;dr is that these files are automatically scoped to the corresponding component/route, which reduces the potential for class name conflicts.
Unfortunately, our CSS is currently a bit of a 🍝 bowl, so it will take some time to untangle this into properly scoped modules.
r? @locks