mirage/crates: Return 404 if specified crate can't be found #2130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors r+ |
|
📌 Commit 30634f7 has been approved by |
bors
added a commit
that referenced
this pull request
Jan 15, 2020
mirage/crates: Return 404 if specified crate can't be found Our `GET /api/v1/crates/:id` mirage request handler was not handling unknown crates the same way as the production API server. This PR fixes the inconsistency by returning a 404 error if the client requests a crate that does not exist on the mock server. r? @locks
|
☀️ Test successful - checks-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our
GET /api/v1/crates/:idmirage request handler was not handling unknown crates the same way as the production API server. This PR fixes the inconsistency by returning a 404 error if the client requests a crate that does not exist on the mock server.r? @locks