Skip to content

CI: Include rustc version in key for target/ cache #2142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 24, 2020

Conversation

jtgeibel
Copy link
Member

Based on a solution suggested by @pietroalbini.

I plan to push a few more things to this branch to test things and will probably drop the cache of rustc. So for now,
r? @ghost

@jtgeibel
Copy link
Member Author

This is ready for review, but for some reason the caching behavior is still sub-optimal. On this branch the 2nd build does restore the build cache from build 1, however, the lint and test steps still recompile about half of the crates. Same for build 3. For some reason, the cache seem to not be working for some dependencies, even though the files in target/ are restored. I don't see any obvious pattern in the list of affected crates either.

We're using the same CARGO_INCREMENTAL: 0 and RUSTFLAGS: "-C debuginfo=0 -D warnings" that helped improve caching on Travis. I think this PR improves the caching situation, but I'm not sure how to troubleshoot the remaining odd behavior.

r? @pietroalbini

@pietroalbini
Copy link
Member

This looks good to me!

@bors r+

@bors
Copy link
Contributor

bors commented Jan 20, 2020

@pietroalbini: 🔑 Insufficient privileges: Not in reviewers

@jtgeibel
Copy link
Member Author

Insufficient privileges: Not in reviewers

How are you not on that list? Here, let me help:
@bors r=pietroalbini

@bors
Copy link
Contributor

bors commented Jan 24, 2020

📌 Commit 239ec4b has been approved by pietroalbini

bors added a commit that referenced this pull request Jan 24, 2020
…bini

CI: Include rustc version in key for `target/` cache

Based on a solution suggested by @pietroalbini.

I plan to push a few more things to this branch to test things and will probably drop the cache of rustc.  So for now,
r? @ghost
@bors
Copy link
Contributor

bors commented Jan 24, 2020

⌛ Testing commit 239ec4b with merge 8b15368...

@bors
Copy link
Contributor

bors commented Jan 24, 2020

☀️ Test successful - checks-travis
Approved by: pietroalbini
Pushing 8b15368 to master...

@bors bors merged commit 239ec4b into rust-lang:master Jan 24, 2020
@jtgeibel jtgeibel deleted the ci/actions/improve-caching branch January 24, 2020 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants