frontend: Document category proposal system and categorization process #2185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The wording, of course, is negotiable. Personally I like the style of "[Condition one might be in]? [How to get oneself out of it]!". Signed-off-by: Kristofer Rye <[email protected]>
I feel bad adding another entire style file, but the overhead should still be pretty dang minimal since this just adjusts a couple of styling bits and bobs. Signed-off-by: Kristofer Rye <[email protected]>
|
r? @smarnach (rust_highfive has picked a reviewer for you, use r? to override) |
jtgeibel
requested changes
Feb 15, 2020
Per review feedback and discussion in the meeting, it seems like a good idea to hold off on adding this just yet. Signed-off-by: Kristofer Rye <[email protected]> Tested-by: Kristofer Rye <[email protected]>
|
Thanks for the update! Visual diff approved in Percy. @bors r+ |
|
📌 Commit 2662550 has been approved by |
bors
added a commit
that referenced
this pull request
Feb 19, 2020
frontend: Document category proposal system and categorization process This PR aims to close #544, and just adds a div and some styles for it. <details><summary>📸 Before</summary><img width="1036" alt="image" src="https://user-images.githubusercontent.com/1566689/74396257-0aa34100-4dd7-11ea-9f77-c27cca629da6.png"></details> <details><summary>📸 After</summary><img width="1040" alt="image" src="https://user-images.githubusercontent.com/1566689/74396288-260e4c00-4dd7-11ea-9c48-04bf3f9c814b.png"></details> Wording and stylesheet placement is absolutely negotiable!
![https://user-images.githubusercontent.com/1566689/74396257-0aa34100-4dd7-11ea-9f77-c27cca629da6.png"></details](https://user-images.githubusercontent.com/1566689/74396257-0aa34100-4dd7-11ea-9f77-c27cca629da6.png"></details){kind=link}
![https://user-images.githubusercontent.com/1566689/74396288-260e4c00-4dd7-11ea-9c48-04bf3f9c814b.png"></details](https://user-images.githubusercontent.com/1566689/74396288-260e4c00-4dd7-11ea-9c48-04bf3f9c814b.png"></details){kind=link}
|
☀️ Test successful - checks-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to close #544, and just adds a div and some styles for it.
📸 Before
📸 After
Wording and stylesheet placement is absolutely negotiable!