Revert changes to update_downloads task in #2157 #2192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears that the additional wrapper transaction added around the update_downloads task causes delays and timeouts to download requests whenever the background job is run. Reverting so that master can be deployed. Revert "Auto merge of rust-lang#2157 - jtgeibel:add-lock-to-update-downloads-job, r=sgrif" This reverts commit c07223b, reversing changes made to c6d13eb.
|
After observing this PR in production, the revert solves the slow and timed-out download requests that were observed after the last deploy. @bors r+ |
|
📌 Commit 5aef9e7 has been approved by |
|
💥 Test timed out |
|
Travis is doing that thing again, where it waits just long enough before spawning jobs so that the builds finish just moments after the timeout. @bors retry |
|
☀️ Test successful - checks-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that the additional wrapper transaction added around the
update_downloads task causes delays and timeouts to download requests
whenever the background job is run. Reverting so that master can be
deployed.
r? @ghost