Fix tests when linking with lld #2466
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``` Updating ghost v0.1.0 -> v0.1.1 Updating inventory v0.1.3 -> v0.1.6 Updating inventory-impl v0.1.3 -> v0.1.6 ```
Turbo87
approved these changes
Apr 29, 2020
JohnTitor
approved these changes
Apr 29, 2020
|
👍 |
|
📌 Commit dfcf28b has been approved by |
|
☀️ Test successful - checks-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bumps a few dependencies (in particular
ctor) to fix linking withlld. Before this fix, tests would fail because the background jobs were not being registered correctly.I'm seeing very promising results with
lldlocally. Here are my times for a clean incremental build (aftertouch src/lib.rs) when runningtime cargo test --no-run:Ubuntu 20.04 default linker
With
RUSTFLAGS="-C link-arg=-fuse-ld=lld"Our production and CI are on an Ubuntu 16.04 stack, so I'm not sure what it would take to make this configuration the default.
r? @JohnTitor