Skip to content

Fix serving /git/index during local development #2469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2020

Conversation

jtgeibel
Copy link
Member

The "index checkout" directory is used to initialize the bare index repo
but is not kept in sync after that. It seems unnecessary to require all
environments to define the GIT_REPO_CHECKOUT variable, so it is
dropped as well.

During local development, the tmp/index-bare repo is automatically
served at /git/index by the HTTP backend.

r? @JohnTitor

The "index checkout" directory is used to initialize the bare index repo
but is not kept in sync after that. It seems unnecessary to require all
environments to define the `GIT_REPO_CHECKOUT` variable, so it is
dropped as well.

During local development, the `tmp/index-bare` repo is automatically
served at `/git/index` by the HTTP backend.
@ehuss
Copy link
Contributor

ehuss commented Apr 30, 2020

Nice! I think this resolves my third issue in #1998.

Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! At a glance, we still have some mentions about index-co in the docs but we could follow-up later.

@JohnTitor
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Apr 30, 2020

📌 Commit 10a1eb8 has been approved by JohnTitor

@bors
Copy link
Contributor

bors commented Apr 30, 2020

⌛ Testing commit 10a1eb8 with merge fa861fe...

@bors
Copy link
Contributor

bors commented Apr 30, 2020

☀️ Test successful - checks-travis
Approved by: JohnTitor
Pushing fa861fe to master...

@bors bors merged commit fa861fe into rust-lang:master Apr 30, 2020
@jtgeibel jtgeibel deleted the fix-dev-git-index-endpoint branch May 11, 2020 23:18
bors added a commit that referenced this pull request May 12, 2020
Remove mentions about `index-co`

Follow-up of #2469
r? @jtgeibel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants