Bump to the latest cookie crate
#2500
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnTitor
approved these changes
May 10, 2020
This upstream release includes several changes: * `cookie` is bumped to 0.13 * `Max-Age` is set to 90 days * `Same-Site=Strict` is added to the session cookie * Only set the session cookie in the response if the session was modified
Now that `cookie 0.13` pulls in `time 0.2`, we bump these crates which also depend on the newer version.
jtgeibel
force-pushed
the
update/cookie-and-time
branch
from
eb0c094 to
faa2cad
Compare
|
Great catches! I had rebased and ended up with some inconsistent state in the lock file. It looks like Travis has a backlog, so bors would probably timeout now waiting for CI to run. I'll start merging some PRs once it looks like that is resolved. |
|
@bors r=JohnTitor |
|
📌 Commit faa2cad has been approved by |
|
☀️ Test successful - checks-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These upstream
conduit-*crates now pull in the latest versions ofcookieandtime.In particular, the following changes to cookie behavior are made:
cookieis bumped to 0.13Max-Ageis set to 90 daysSame-Site=Strictis added to the session cookier? @JohnTitor