Skip to content

Replace {{ title }} with {{page-title}} #2570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/templates/categories.hbs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{ title 'Categories' }}
{{page-title 'Categories'}}

<PageHeader @title="All Categories"/>

Expand Down
2 changes: 1 addition & 1 deletion app/templates/category-slugs.hbs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{ title 'Category Slugs' }}
{{page-title 'Category Slugs'}}

<PageHeader @title="All Valid Category Slugs"/>

Expand Down
2 changes: 1 addition & 1 deletion app/templates/category/error.hbs
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{{ title 'Category Not Found' }}
{{page-title 'Category Not Found'}}
2 changes: 1 addition & 1 deletion app/templates/category/index.hbs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{ title this.category.category ' - Categories' }}
{{page-title this.category.category ' - Categories'}}

<PageHeader local-class="header">
<LinkTo @route="categories" aria-label="Categories">{{svg-jar "crate"}}</LinkTo>
Expand Down
2 changes: 1 addition & 1 deletion app/templates/crate/error.hbs
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{{ title 'Crate Not Found' }}
{{page-title 'Crate Not Found'}}
2 changes: 1 addition & 1 deletion app/templates/crate/owners.hbs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{ title 'Manage Crate Owners' }}
{{page-title 'Manage Crate Owners'}}

<PageHeader
@title="Manager Crate Owners"
Expand Down
2 changes: 1 addition & 1 deletion app/templates/crates.hbs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{ title 'Crates' }}
{{page-title 'Crates'}}

<PageHeader @title="All Crates" @suffix={{if this.letter (concat "starting with '" this.letter "'")}}/>

Expand Down
2 changes: 1 addition & 1 deletion app/templates/dashboard.hbs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{ title 'Dashboard' }}
{{page-title 'Dashboard'}}

<PageHeader local-class="header">
{{svg-jar "dashboard" local-class="header-icon"}}
Expand Down
2 changes: 1 addition & 1 deletion app/templates/keyword/error.hbs
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{{ title 'Keyword Not Found' }}
{{page-title 'Keyword Not Found'}}
2 changes: 1 addition & 1 deletion app/templates/keyword/index.hbs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{ title this.keyword.keyword ' - Keywords' }}
{{page-title this.keyword.keyword ' - Keywords'}}

<PageHeader @title="All Crates" @suffix="for keyword '{{this.keyword.keyword}}'"/>

Expand Down
2 changes: 1 addition & 1 deletion app/templates/keywords.hbs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{ title 'Keywords' }}
{{page-title 'Keywords'}}

<PageHeader @title="All Keywords"/>

Expand Down
2 changes: 1 addition & 1 deletion app/templates/me/crates.hbs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{ title 'My Crates' }}
{{page-title 'My Crates'}}

<PageHeader @title="My Crates"/>

Expand Down
2 changes: 1 addition & 1 deletion app/templates/me/index.hbs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{ title 'Settings' }}
{{page-title 'Settings'}}

<PageHeader @title="Account Settings" @icon="gear"/>

Expand Down
2 changes: 1 addition & 1 deletion app/templates/me/pending-invites.hbs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{ title 'Pending Invites' }}
{{page-title 'Pending Invites'}}

<PageHeader @title="Pending Owner Invites" @icon="gear"/>

Expand Down