Skip to content

Replace custom flash message implemenation with ember-cli-notifications #2588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Aug 18, 2020

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Jun 17, 2020

@Turbo87 Turbo87 added C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works A-frontend 🐹 labels Jun 17, 2020
@Turbo87 Turbo87 force-pushed the notifications branch 2 times, most recently from eed6e57 to 80c2b08 Compare June 17, 2020 22:49
@bors
Copy link
Contributor

bors commented Jun 22, 2020

☔ The latest upstream changes (presumably #2594) made this pull request unmergeable. Please resolve the merge conflicts.

@Turbo87 Turbo87 requested a review from locks July 5, 2020 08:21
@locks
Copy link
Contributor

locks commented Jul 5, 2020

The lockfile seems to have a conflict!

@Turbo87
Copy link
Member Author

Turbo87 commented Aug 18, 2020

@bors r=@locks

@bors
Copy link
Contributor

bors commented Aug 18, 2020

📌 Commit ece0d96 has been approved by locks

@bors
Copy link
Contributor

bors commented Aug 18, 2020

⌛ Testing commit ece0d96 with merge 1d53a67...

@bors
Copy link
Contributor

bors commented Aug 18, 2020

☀️ Test successful - checks-travis
Approved by: locks
Pushing 1d53a67 to master...

@bors bors merged commit 1d53a67 into rust-lang:master Aug 18, 2020
@Turbo87 Turbo87 deleted the notifications branch August 23, 2020 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-frontend 🐹 C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants