Fix logging of original request path #2616
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the original implementation the logging middleware would log the final rewritten path. The NormalizePath middleware had custom logic to log the original path, but the other 2 uses of path_mut() were not handled consistently. The logging middleware now ensures that the original request path is always logged.
jtgeibel
force-pushed
the
fix-path-rewrite-logging
branch
from
53fafee to
29eadd0
Compare
JohnTitor
approved these changes
Jul 9, 2020
|
@bors r+ |
|
📌 Commit 29eadd0 has been approved by |
|
☀️ Test successful - checks-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the original implementation the logging middleware would log the
final rewritten path. The NormalizePath middleware had custom logic
to log the original path, but the other 2 uses of path_mut() were not
handled consistently. The logging middleware now ensures that the
original request path is always logged.
r? @JohnTitor