Cleanup backend json error structs #2625
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The error types maps to status `403 Forbidden`, not `400 Unauthorized`.
Some direct usage exists so the NotFound type is also re-exported.
The remaining helper structs that build json errors were also moved to this module.
jtgeibel
changed the title
JohnTitor
approved these changes
Jul 13, 2020
|
@bors r+ |
|
📌 Commit 75a3eec has been approved by |
|
☀️ Test successful - checks-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finish some cleanup work for how JSON error messages are generated. All associated types are moved to
errors::json.Going forward, there is some direct usage of
Response::builder()in the middleware. These return text instead of JSON. We should look into this usage to see if some of them should be switched to JSON. For any remaining we could consider a set oferrors::texthelpers.r? @JohnTitor