Obtain allowed origin list from the environment #2659
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnTitor
approved these changes
Jul 26, 2020
jsha
reviewed
Jul 26, 2020
This adapts the scheme added in rust-lang#2627. When operating behind CloudFront, the Host received by nginx is the Heroku instance and does not match the user facing crates.io origin. Therefore it is necessary to obtain a list of allowed origins at boot time. If this header is not set, the server will panic and will not boot.
jtgeibel
force-pushed
the
update-origin-check
branch
from
cd9ef24 to
a7a2256
Compare
|
No worries, I didn't either! I plan to redeploy sometime tomorrow morning (EDT). @bors r+ |
|
📌 Commit a7a2256 has been approved by |
|
☀️ Test successful - checks-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adapts the scheme added in #2627. When operating behind
CloudFront, the Host received by nginx is the Heroku instance and does
not match the user facing crates.io origin. Therefore it is necessary to
obtain a list of allowed origins at boot time.
If this header is not set, the server will panic and will not boot.
r? @JohnTitor
cc @jsha