Double nginx worker connections #2785
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should double our burst capacity during large influxes of download traffic and reduce the occurance of H13 errors due to hitting the worker connection limit. With more queued connections we could potentially bump into limits on the number of open file handles. It looks like Heroku dynos have a ulimit on open files of: * 10,000 for Standard-1X dynos * 1,048,576 for Performance-M dynos Based on these numbers, we have a margin of 1,808 file handles for database connections, serving static files, etc. even on a Standard-1X dyno.
CloudFront with "helpfully" replace an empty/missing user-agent header with "Amazon CloudFront", so we have to treat that as equivalent to an empty header.
pietroalbini
approved these changes
Sep 12, 2020
jtgeibel
force-pushed
the
double-nginx-worker-connections
branch
from
c3ef76d to
f372d6f
Compare
|
@bors r+ |
|
📌 Commit f372d6f has been approved by |
|
☀️ Test successful - checks-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should double our burst capacity during large influxes of download
traffic and reduce the occurance of H13 errors due to hitting the worker
connection limit.
With more queued connections we could potentially bump into limits on
the number of open file handles. It looks like Heroku dynos have a
ulimit on open files of:
Based on these numbers, we have a margin of 1,808 file handles for
database connections, serving static files, etc. even on a Standard-1X
dyno.
r? @pietroalbini