mirage: Untangle crate.id and crate.name
#3698
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `id` is rarely used and exposed on the API, but there are a few cases where it is indeed used. The `id` is meant to be a `i32` though, so having it equal to the `name` of the crate was wrong. This commit fixes the issue by having the `id` as a regular numeric ID and using `name` everywhere else.
Turbo87
added
A-frontend 🐹
C-internal 🔧
|
@bors r+ |
|
📌 Commit 040bc68 has been approved by |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
idis rarely used and exposed on the API, but there are a few cases where it is indeed used. Theidis meant to be ai32though, so having it equal to thenameof the crate was wrong. This PR fixes the issue by having theidas a regular numeric ID and usingnameeverywhere else.This PR is a prerequisite for implementing
crate-owner-invitationsupport into our mirage setup.