Add more histograms #3775
Merged
Add more histograms #3775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
added
A-backend ⚙️
C-internal 🔧
|
LGTM @bors r+ |
|
📌 Commit 2fff66c has been approved by |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds more histograms to the metrics we collect, exposing information that could be useful when we get paged. Two metrics were added:
cratesio_instance_database_time_to_obtain_connection: how long it takes to obtain a database connectioncratesio_instance_downloads_select_query_execution_time: how long theSELECTin the download endpoint takesA side effect of this is that
TimingRecorderis not needed anymore: we used it to measure those two things, appending them in the logs for slow requests, but now that we have metrics there is no need to have it. If we need to measure more timings in the future we can just add more histograms. This PR thus removesTimingRecorderfrom the codebase.r? @jtgeibel or @Turbo87
This can be reviewed commit-by-commit.