Match monospace font with main font #3902
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @smarnach (or someone else) soon. Please see the contribution instructions for more information. |
Turbo87
added
A-frontend 🐹
C-enhancement ✨
Since Fira Sans is used across crates.io, it makes sense to use Fira Mono for monospaced text to increase consistency. After Fira Mono there is now `ui-monospace` in the font stack, which renders as SF Mono on macOS Safari without having to manually install SF Mono. `ui-monospace` is part of the CSS Fonts Module Level 4 draft: https://www.w3.org/TR/css-fonts-4/#ui-monospace-def.
|
LGTM! 👍 @bors r+ |
|
📌 Commit 8740eea has been approved by |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Fira Sans is used across crates.io, it makes sense to use Fira Mono for monospaced text to increase consistency. After Fira Mono there is now
ui-monospacein the font stack, which renders as SF Mono on Safari without having to manually install SF Mono.ui-monospaceis part of the CSS Fonts Module Level 4 draft.