Skip to content

sentry: Simplify init() function #3981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 6, 2021
Merged

sentry: Simplify init() function #3981

merged 2 commits into from
Oct 6, 2021

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Oct 5, 2021

sentry::init() already expects an Option<Dsn> so there is no reason for us to only call it if the env var exists. This reduces the nesting and simplfies the big .map() implementation.

@Turbo87 Turbo87 added C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear A-backend ⚙️ labels Oct 5, 2021
@Turbo87 Turbo87 requested review from JohnTitor and 0xPoe October 5, 2021 20:13
`sentry::init()` already expects an `Option<Dsn>` so there is no reason for us to only call it if the env var exists. This reduces the nesting and simplfies the big `.map()` implementation.
Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@JohnTitor
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Oct 6, 2021

📌 Commit d19d28c has been approved by JohnTitor

@bors
Copy link
Contributor

bors commented Oct 6, 2021

⌛ Testing commit d19d28c with merge 418eef4...

@bors
Copy link
Contributor

bors commented Oct 6, 2021

☀️ Test successful - checks-actions
Approved by: JohnTitor
Pushing 418eef4 to master...

@bors bors merged commit 418eef4 into rust-lang:master Oct 6, 2021
@Turbo87 Turbo87 deleted the sentry branch October 7, 2021 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-backend ⚙️ C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants