database: Simplify trigger_versions_set_updated_at trigger on the versions table
#3993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
added
C-internal 🔧
…versions` table The only mutable columns in this table are `yanked` and `downloads`, but the trigger should specifically not be used when the `downloads` column changes. That means we're only left with the `yanked` column and can be more specific in the trigger condition.
Turbo87
force-pushed
the
simplify-trigger
branch
from
a442ffb to
9dcf3c7
Compare
|
The change seems simple enough 👍 @bors r+ |
|
📌 Commit 9dcf3c7 has been approved by |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only mutable columns in this table are
yankedanddownloads, but the trigger should specifically not be used when thedownloadscolumn changes. That means we're only left with theyankedcolumn and can be more specific in the trigger condition.This unblocks #3992, but also generally simplifies the table trigger.