Skip to content

Use ResizeObserver polyfill, if necessary #4012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 14, 2021

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Oct 14, 2021

This shouldn't be necessary due to our browser support policy (see https://caniuse.com/mdn-api_resizeobserver), but we seem to have plenty of users that regularly run into this, due to Chart.js using the ResizeObserver API underneath.

The polyfill is loaded async if we detect that ResizeObserver is not implemented natively in the browser.

see https://github.com/juggle/resize-observer

Fixes #4011

@Turbo87 Turbo87 added C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works A-frontend 🐹 labels Oct 14, 2021
@Turbo87 Turbo87 requested review from locks and pichfl October 14, 2021 08:20
@locks
Copy link
Contributor

locks commented Oct 14, 2021

@bors r+

@bors
Copy link
Contributor

bors commented Oct 14, 2021

📌 Commit aaac029 has been approved by locks

@bors
Copy link
Contributor

bors commented Oct 14, 2021

⌛ Testing commit aaac029 with merge 14183de...

@bors
Copy link
Contributor

bors commented Oct 14, 2021

☀️ Test successful - checks-actions
Approved by: locks
Pushing 14183de to master...

@bors bors merged commit 14183de into rust-lang:master Oct 14, 2021
@Turbo87 Turbo87 deleted the resize-polyfill branch October 14, 2021 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-frontend 🐹 C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ReferenceError: Can't find variable: ResizeObserver
3 participants