Clean up Header component
#4013
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still with two input elements though, due to the different placeholders
Turbo87
added
A-frontend 🐹
C-internal 🔧
Turbo87
force-pushed
the
header-cleanup
branch
from
12b760d to
9e9134a
Compare
|
@bors r+ |
|
📌 Commit 9e9134a has been approved by |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up our
<Header />component. The primary goal was to fix the last remaining template-lint warning about having two search forms on the page. Instead of having two, we now have only one, but with two input fields inside of it, to allow us to use different placeholders, depending on the screen size. Visually, the header should still look essentially the same as before, except for a few small padding/margin adjustments.