Skip to content

CI: Simplify rustup usage #4075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 22, 2021
Merged

CI: Simplify rustup usage #4075

merged 2 commits into from
Oct 22, 2021

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Oct 22, 2021

  • rustup uses the minimal profile by default on GitHub Actions
  • We don't need the custom rustup installation anymore

@Turbo87 Turbo87 added C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear A-backend ⚙️ labels Oct 22, 2021
@Turbo87 Turbo87 requested review from JohnTitor and locks October 22, 2021 09:34
Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍, r=me once a conflict from #4072 is resolved

@bors
Copy link
Contributor

bors commented Oct 22, 2021

☔ The latest upstream changes (presumably #4072) made this pull request unmergeable. Please resolve the merge conflicts.

CI is already using the `minimal` profile by default and the `rustup update` call seems to be unnecessary
This is no longer necessary
@Turbo87
Copy link
Member Author

Turbo87 commented Oct 22, 2021

@bors r=JohnTitor

@bors
Copy link
Contributor

bors commented Oct 22, 2021

📌 Commit 115e633 has been approved by JohnTitor

@bors
Copy link
Contributor

bors commented Oct 22, 2021

⌛ Testing commit 115e633 with merge b7132dd...

@bors
Copy link
Contributor

bors commented Oct 22, 2021

☀️ Test successful - checks-actions
Approved by: JohnTitor
Pushing b7132dd to master...

@bors bors merged commit b7132dd into rust-lang:master Oct 22, 2021
@Turbo87 Turbo87 deleted the simplify-ci branch October 22, 2021 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-backend ⚙️ C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants