Add explicit @ember/test-waiters dependency
#4086
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
added
A-frontend 🐹
C-internal 🔧
|
I mean, it's good practice to explicitely depend on your dependencies :P |
|
📌 Commit b1533cf has been approved by |
bors
added a commit
that referenced
this pull request
Oct 25, 2021
Add explicit `@ember/test-waiters` dependency We are using this package in the `DownloadsGraph` component, so we should be explicit about the dependency, instead of relying on other addons bringing this in. And if you ask why this matters: because https://github.com/embroider-build/embroider/ will complain otherwise 😉
|
💔 Test failed - checks-actions |
|
☔ The latest upstream changes (presumably #4088) made this pull request unmergeable. Please resolve the merge conflicts. |
We are using this package in the `DownloadsGraph` component, so we should be explicit about the dependency, instead of relying on other addons bringing this in.
|
@bors r=locks |
|
📌 Commit b692e6e has been approved by |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using this package in the
DownloadsGraphcomponent, so we should be explicit about the dependency, instead of relying on other addons bringing this in.And if you ask why this matters: because https://github.com/embroider-build/embroider/ will complain otherwise 😉