Skip to content

Cargo: Enable doctests again #4248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 12, 2021
Merged

Cargo: Enable doctests again #4248

merged 2 commits into from
Dec 12, 2021

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Dec 8, 2021

They were disabled in 2014 for some unknown reason, but these days there is really no reason to have them disabled.

We barely write any comments, but if we do then we should make sure that they compile and work
@Turbo87 Turbo87 added the C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear label Dec 8, 2021
@Turbo87 Turbo87 requested a review from JohnTitor December 8, 2021 22:58
@Turbo87
Copy link
Member Author

Turbo87 commented Dec 12, 2021

@bors r+

@bors
Copy link
Contributor

bors commented Dec 12, 2021

📌 Commit 7a20ce8 has been approved by Turbo87

@bors
Copy link
Contributor

bors commented Dec 12, 2021

⌛ Testing commit 7a20ce8 with merge 2c71b2a...

@bors
Copy link
Contributor

bors commented Dec 12, 2021

☀️ Test successful - checks-actions
Approved by: Turbo87
Pushing 2c71b2a to master...

@bors bors merged commit 2c71b2a into rust-lang:master Dec 12, 2021
@Turbo87 Turbo87 deleted the doc-tests branch December 12, 2021 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants